Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple listeners being attached to models #192

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Fl0Cri
Copy link
Contributor

@Fl0Cri Fl0Cri commented Nov 18, 2024

Fixes wintercms/winter#1251 by replacing all instances of bindEvent inside a Laravel Model Event by bindEventOnce.

As mentioned in the issue above, there's still an edge case if the event is cancelled by another listener.

Fixes wintercms/winter#1251
As mentioned in the issue above, there's still an edge case if the event is cancelled by another listener.
@LukeTowers LukeTowers merged commit 626409c into wintercms:develop Nov 20, 2024
10 checks passed
@LukeTowers LukeTowers added this to the 1.2.7 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model events fired multiple times
2 participants