fix Halcyon model

wintercms · Jan 29, 2024 · 191a4bd · 191a4bd
1 parent 3fcbcc0
commit 191a4bd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/Extension/ExtendableTrait.php b/src/Extension/ExtendableTrait.php
@@ -210,7 +210,6 @@ public function addDynamicProperty($dynamicName, $value = null)
         self::$extendableGuardProperties = false;
 
         array_set($this->extensionData['dynamicProperties'], $dynamicName, $value);
-        $this->extendableSet($dynamicName, $value);
 
         self::$extendableGuardProperties = true;
     }
@@ -419,7 +418,7 @@ public function extendableSet($name, $value)
          * Setting an undefined property
          */
         if (!self::$extendableGuardProperties) {
-            $this->{$name} = $value;
+            array_set($this->extensionData['dynamicProperties'], $name, $value);
         }
     }
 

diff --git a/src/Halcyon/Model.php b/src/Halcyon/Model.php
@@ -1603,6 +1603,15 @@ public static function cacheMutatedAttributes($class)
         static::$mutatorCache[$class] = $mutatedAttributes;
     }
 
+    public function addDynamicProperty($dynamicName, $value = null)
+    {
+        if (isset($this->attributes[$dynamicName])) {
+            return;
+        }
+
+        $this->setAttribute($dynamicName, $value);
+    }
+
     /**
      * Dynamically retrieve attributes on the model.
      *