Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markup - Added custom filters and functions #181

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

WebVPF
Copy link
Contributor

@WebVPF WebVPF commented Mar 22, 2024

@mjauvin
Copy link
Member

mjauvin commented Mar 22, 2024

This already exists under the Plugin Registration section.

@WebVPF
Copy link
Contributor Author

WebVPF commented Mar 22, 2024

This already exists under the Plugin Registration section.

@mjauvin Where? Can you show the link?

@WebVPF
Copy link
Contributor Author

WebVPF commented Mar 22, 2024

@mjauvin Did you see what I added to the pull request? And where did I add.

@mjauvin
Copy link
Member

mjauvin commented Mar 22, 2024

@mjauvin Did you see what I added to the pull request? And where did I add.

Yes.
I guess it doesn't hurt to add this in there.

@WebVPF
Copy link
Contributor Author

WebVPF commented Mar 22, 2024

@mjauvin thanks for sorting it out


I know that you can add your own Twig filters and functions. I've used this more than once. But I don’t remember where and how they need to be defined. So I open the documentation.
I don't remember where in the documentation it is stated about this. So I start looking. Having searched and not found, I go to the Markup section, it is logical that there should be some mention of this in this section.
Finding nothing, I return back to the Winter documentation. I find the right method, but not right away.
It turns out I'm wasting a lot of time.

This has happened to me several times already. So I added a link to the Markup documentation. It should be there to make it easier to find.

@WebVPF WebVPF changed the base branch from develop to 1.2 April 3, 2024 05:12
@WebVPF
Copy link
Contributor Author

WebVPF commented Apr 4, 2024

@LukeTowers accept this PR

@LukeTowers LukeTowers merged commit 2e174db into wintercms:1.2 Apr 4, 2024
1 check passed
@WebVPF WebVPF deleted the patch-1 branch April 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants