-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WINDUP-4115 CVE upgrade css-tools #983
Conversation
ui-pf4/src/main/webapp/package.json
Outdated
@@ -5,6 +5,7 @@ | |||
"proxy": "http://localhost:8080", | |||
"homepage": "./", | |||
"dependencies": { | |||
"@adobe/css-tools": "^4.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is not a direct dependency for the UI. It is better to set this line under the resolutions
section of the package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line has been moved as suggested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as windup/windup#1739
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @m-brophy
* WINDUP-4115 CVE upgrade css-tools * WINDUP-4115 place css-tools in resolutions section (cherry picked from commit b136f5a)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* WINDUP-4115 CVE upgrade css-tools * WINDUP-4115 place css-tools in resolutions section (cherry picked from commit b136f5a) Co-authored-by: Mark Brophy <[email protected]>
https://issues.redhat.com/browse/WINDUP-4115
https://issues.redhat.com/browse/WINDUP-4098
https://bugzilla.redhat.com/show_bug.cgi?id=2254559