Fixed crashes caused by the resource leak of mutex

include/network/network_downloader.hpp

@@ -34,6 +34,8 @@ struct NetworkStream {
 	bool livestream_eof = false;
 	bool livestream_private = false;
 
+	~NetworkStream();
+
 	// if `whole_download` is true, it will not use Range request but download the whole content at once (used for livestreams)
 	NetworkStream (std::string url, bool whole_download, NetworkSessionList *session_list);
 

source/network/network_decoder.cpp

@@ -455,6 +455,11 @@ void NetworkDecoder::deinit() {
 	free(sw_video_output_tmp);
 	sw_video_output_tmp = NULL;
 
+	if (buffered_pts_list_lock) {
+		svcCloseHandle(buffered_pts_list_lock);
+		buffered_pts_list_lock = 0;
+	}
+
 	// ffmpeg data should not be freed, but to prevent accesses to them, we set NULLs here
 	for (int type = 0; type < 2; type++) {
 		network_stream[type] = NULL;
@@ -519,11 +524,19 @@ Result_with_string NetworkDecoder::init_output_buffer(bool is_mvd) {
 
 Result_with_string NetworkDecoder::init(bool request_hw_decoder) {
 	Result_with_string result;
+	Result libctru_result;
 
 	hw_decoder_enabled = request_hw_decoder;
 	interrupt = false;
 
-	svcCreateMutex(&buffered_pts_list_lock, false);
+	libctru_result = svcCreateMutex(&buffered_pts_list_lock, false);
+	if (libctru_result != 0) {
+		Util_log_save("debug", "decoder mutex fail");
+		usleep(1000000);
+		result.code = libctru_result;
+		result.error_description = "Failed to create mutex";
+		return result;
+	}
 
 	if (!audio_only) {
 		result = init_output_buffer(request_hw_decoder);

source/network/network_downloader.cpp

@@ -10,6 +10,10 @@
 NetworkStream::NetworkStream(std::string url, bool whole_download, NetworkSessionList *session_list) : url(url), whole_download(whole_download), session_list(session_list) {
 	svcCreateMutex(&downloaded_data_lock, false);
 }
+NetworkStream::~NetworkStream() {
+	svcCloseHandle(downloaded_data_lock);
+	downloaded_data_lock = 0;
+}
 bool NetworkStream::is_data_available(u64 start, u64 size) {
 	if (!ready) return false;
 	if (start + size > len) return false;