Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method for using structs / json to access attributes #842

Merged
merged 10 commits into from
Nov 25, 2024

adding errors and tests to errors when finding attributes

89002a7
Select commit
Loading
Failed to load commit list.
Merged

Method for using structs / json to access attributes #842

adding errors and tests to errors when finding attributes
89002a7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 25, 2024 in 0s

77.19% (+0.43%) compared to 9cd80db

View this Pull Request on Codecov

77.19% (+0.43%) compared to 9cd80db

Details

Codecov Report

Attention: Patch coverage is 93.55828% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.19%. Comparing base (9cd80db) to head (89002a7).

Files with missing lines Patch % Lines
...h/src/wmtk/components/multimesh/MeshCollection.cpp 31.25% 11 Missing ⚠️
.../wmtk/components/multimesh/utils/get_attribute.cpp 94.56% 5 Missing ⚠️
...omponents/multimesh/utils/AttributeDescription.cpp 92.00% 2 Missing ⚠️
...onents/multimesh/utils/detail/named_error_text.cpp 88.23% 2 Missing ⚠️
components/multimesh/tests/utils.cpp 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   76.76%   77.19%   +0.43%     
==========================================
  Files         466      476      +10     
  Lines       23376    23643     +267     
  Branches     2620     2634      +14     
==========================================
+ Hits        17945    18252     +307     
+ Misses       5420     5380      -40     
  Partials       11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov