Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always export vertex attributes in paraview #841

Merged
merged 2 commits into from
Nov 27, 2024
Merged

always export vertex attributes in paraview #841

merged 2 commits into from
Nov 27, 2024

Conversation

teseoch
Copy link
Collaborator

@teseoch teseoch commented Nov 21, 2024

No description provided.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (5179fbf) to head (fb571b5).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/wmtk/io/ParaviewWriter.cpp 64.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   76.76%   77.17%   +0.41%     
==========================================
  Files         466      476      +10     
  Lines       23376    23658     +282     
  Branches     2620     2641      +21     
==========================================
+ Hits        17945    18259     +314     
+ Misses       5420     5388      -32     
  Partials       11       11              
Flag Coverage Δ
wildmeshing 77.17% <64.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniel-zint daniel-zint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust

@@ -92,6 +92,16 @@ TEST_CASE("paraview_2d", "[io]")
mesh->serialize(writer);
}

TEST_CASE("paraview_2d_vtag", "[io]")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a [.] this is not a real test

@teseoch teseoch merged commit 574cfec into main Nov 27, 2024
6 of 9 checks passed
@teseoch teseoch deleted the teseo/outv branch November 27, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants