SimplicialComplex test autogen #361

zlyfunction · 2023-09-11T19:55:49Z

add autogenerated tests for SimplicalComplex tests for 2d

tests/auto_generated/SimplicialComplex.py

mtao · 2023-09-11T21:41:19Z

tests/auto_generated/SimplicialComplex.py

+class Mesh:
+    def __init__(self):
+        self.vertices = []    # List of vertices
+        self.tetrahedra = []  # List of tetrahedra


why switch for tets? i assume the class is supposed to be agnostic to tri vs tet meshes?

tets will alway be the top simplex, so there will be no redundant tets in init.

sure, but why not just use sets and tuples in this implementation instead of switching back and forth between things?

tests/auto_generated/SimplicialComplex.py

tests/auto_generated/SimplicialComplex_test_autogen.py

mtao · 2023-09-11T23:52:27Z

tests/auto_generated/SimplicialComplex_test_autogen.py

+# Write test code
+with open(output_file_name, 'w') as file:
+    write_cpp_headers(file)
+    for mesh_name in mesh_names:


i would write one file per mesh, i think these will get rather large and it's better to split the compilation up. If we want to optimize the sizes of our outputs I think we should change how the test files are written (like having a table + unit tests that compare against a table rather than repeat the word REQUIRE and CHECK so many times).

that would be a future issue/PR

tests/auto_generated/SimplicialComplex_test_autogen.py

mtao · 2023-09-12T02:10:49Z

tests/auto_generated/SimplicialComplex_test_autogen.py

+
+
+# Parameters
+path = '../../data/'


this path might not be canonical so it should be an argument for the script with some instructions on what should be found in the path (such as being some subfolder of WMTK_DATA_DIR?)

daniel-zint

I need to double check if all cases are covered by the tests. Otherwise, I added some minor comments.

daniel-zint · 2023-09-20T02:31:18Z

tests/auto_generated/test_simplicial_complex_2d.cpp

+    RowVectors3d V;
+    RowVectors3l F;
+    std::string name = "/circle.obj";
+    std::string path;


use std::filesystem::path

daniel-zint · 2023-09-20T02:33:11Z

tests/tools/DEBUG_TriMesh.cpp

+std::vector<std::vector<long>> DEBUG_TriMesh::get_sorted_simplicial_complex(const std::vector<Simplex> &sc) const
+{
+    std::vector<std::vector<long>> ret;
+    for (auto s : sc)


for(const auto& s : sc)

daniel-zint · 2023-09-20T02:34:34Z

tests/tools/DEBUG_TriMesh.cpp

@@ -174,4 +173,41 @@ auto DEBUG_TriMesh::get_tmoe(const Tuple& t, Accessor<long>& hash_accessor)
 {
    return TriMeshOperationExecutor(*this, t, hash_accessor);
 }
+
+std::vector<std::vector<long>> DEBUG_TriMesh::get_sorted_simplicial_complex(const std::vector<Simplex> &sc) const


The name of this function is not very intuitive. Please, either provide a better name or add a comment describing what this function does.

daniel-zint · 2023-09-20T02:37:52Z

tests/auto_generated/test_simplicial_complex_2d.cpp

+    Tuple t;
+    std::vector<std::vector<long>> sc_v, sc_e, sc_f;
+    t = m.tuple_from_id(PV, 5058);
+    sc_v = m.get_sorted_simplicial_complex(SimplicialComplex::open_star(m, Simplex(PV, t)).get_simplex_vector());


I'd prefer const auto sc_v = ... here.

daniel-zint · 2023-09-20T02:45:08Z

tests/auto_generated/test_simplicial_complex_2d_hard.cpp

+{
+    RowVectors3d V;
+    RowVectors3l F;
+    std::string name = "/circle_0.7.obj";


I don't think that file is in the data repo

There is a code to generate this, but I am not sure if we want this in the data repo

this belongs in the data repo - separate your code for auto-generating meshes and for validating meshes into two parts:

generation goes in teh data repo + some generated meshes

test generation lives in tests/auto_generated/

daniel-zint

There are some function tests missing.

daniel-zint · 2023-09-20T17:27:04Z

tests/auto_generated/SimplicialComplex_test_autogen.py

+path = '../../data/'
+mesh_names = ['circle.obj', 'bunny.obj','blub.obj']
+output_file_name = 'test_simplicial_complex_2d.cpp'
+test_function_names = ['open_star', 'closed_star', 'link', 'simplex_with_boundary', 'top_coface_simplex']


missing functions that should be tested

boundary

simplices_w_boundary_intersect

link_cond

vertex_one_ring

k_ring

daniel-zint · 2023-09-20T17:44:55Z

tests/auto_generated/SimplicialComplex_test_autogen.py

+        for _ in range(n_bd_samples):
+            index = random.choice(indices)  # Choose a random index
+            v_samples.append((bd_loop[index],))
+            e_samples.append(tuple(sorted([bd_loop[index], bd_loop[(index + 1) % len(bd_loop)]])))


You should also test edges that are incident to the boundary, i.e. one vertex on the boundary and one on the interior. The same holds for faces.

Also, there might be edges that are interior but both vertices are on the boundary. Any possible combination should be tested.

mtao · 2023-10-03T19:26:01Z

also, auto_generated should just be our scripts folder - which already handles our other autogen code

zlyfunction added 2 commits September 11, 2023 15:29

put sorted_sc to DEBUG_TriMesh

554c5e3

add autogen tests

25cdc07

zlyfunction requested a review from mtao September 11, 2023 19:55

zlyfunction added 3 commits September 11, 2023 16:55

add tests on boundary

a8b3abf

terrible bug fix

68002ab

Merge branch 'hackathon/dev' of https://github.com/wildmeshing/wildme…

dd533eb

…shing-toolkit into sc_test_autogen

mtao linked an issue Sep 11, 2023 that may be closed by this pull request

Automated tests of Simplicial Complex operations #363

Open

mtao requested changes Sep 12, 2023

View reviewed changes

zlyfunction added 4 commits September 14, 2023 11:37

temporary code to generate models with holes to test on

fad93bb

modify code

8c75177

delete notebook

15190de

getattr

3687ecc

mtao marked this pull request as draft September 20, 2023 01:54

daniel-zint reviewed Sep 20, 2023

View reviewed changes

mtao changed the base branch from hackathon/dev to main September 22, 2023 20:42

fix collapse

93078ed

Merge branch 'main' into sc_test_autogen

c871d81

zlyfunction changed the title ~~Sc test autogen~~ SimplicialComplex test autogen Oct 4, 2023

mtao mentioned this pull request Oct 5, 2023

removing simplicial complex tests #422

Merged

daniel-zint closed this Oct 30, 2024

daniel-zint deleted the sc_test_autogen branch October 30, 2024 17:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SimplicialComplex test autogen #361

SimplicialComplex test autogen #361

zlyfunction commented Sep 11, 2023

mtao Sep 11, 2023

zlyfunction Sep 15, 2023

mtao Sep 16, 2023

mtao Sep 11, 2023

mtao Sep 11, 2023

mtao Sep 12, 2023

daniel-zint left a comment

daniel-zint Sep 20, 2023

daniel-zint Sep 20, 2023

daniel-zint Sep 20, 2023

daniel-zint Sep 20, 2023

daniel-zint Sep 20, 2023

zlyfunction Sep 20, 2023

mtao Sep 20, 2023

daniel-zint left a comment

daniel-zint Sep 20, 2023

daniel-zint Sep 20, 2023

daniel-zint Sep 20, 2023

mtao commented Oct 3, 2023

SimplicialComplex test autogen #361

SimplicialComplex test autogen #361

Conversation

zlyfunction commented Sep 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtao commented Oct 3, 2023