Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return event types as df and use event_id as index in get_events #44

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

ericgitonga
Copy link
Contributor

Changes made to earthranger.py to have the dataframe returned by get_events() use the event_id as the index, and to have get_event_types() return a dataframe.

Copy link
Collaborator

@walljcg walljcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the include_schema parameter do? Do you know what the schema is?

@ericgitonga
Copy link
Contributor Author

What does the include_schema parameter do? Do you know what the schema is?

As per the API, it is supposed to return the schema specified in an event types definition. When you run the command through the interactive API, you get the schema returned. However, when you run through the ER code, that doesn't happen. It looks like it is just an informational parameter that doesn't serve any real need as far as I can tell. It is, therefore, safe to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants