-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_patrols_from_id() function #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming of this function is confusing to me. Maybe call it get_patrols_from_patrol_type_id so that we're explicit?
I get your confusion, and on looking at the code again, I realise that get_patrols_from_patrol_type_id is not the right name either. We are pulling patrol segments from particular patrol IDs, and it is from those segments that we then extract the events. A fitting name would therefore be get_patrol_segments_from_patrol_id. |
No description provided.