Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean timestamps from ER geojson in get_patrol_events #358

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Clean timestamps from ER geojson in get_patrol_events #358

merged 1 commit into from
Dec 12, 2024

Conversation

atmorling
Copy link
Contributor

Closes #356

@atmorling
Copy link
Contributor Author

The tests in test_earthranger_utils.py already cover the specific format in #356

@atmorling atmorling mentioned this pull request Dec 11, 2024
Closed
cisaacstern
cisaacstern approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for delay, finally was able to verify this against https://github.com/wildlife-dynamics/ecoscope-platform-workflow-issues/issues/10, I and LGTM! Elegant solution, alex!!

@atmorling atmorling merged commit f44cd7d into master Dec 12, 2024
5 checks passed
@atmorling atmorling deleted the am/events_geojson_datetime branch December 12, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cisaacstern cisaacstern cisaacstern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In EarthRangerIO.get_patrol_events, geojson datetime format is not always "%Y-%m-%dT%H:%M:%S%z"
2 participants
@atmorling @cisaacstern