Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements #341

Merged
merged 35 commits into from
Dec 4, 2024
Merged

Test improvements #341

merged 35 commits into from
Dec 4, 2024

Conversation

atmorling
Copy link
Contributor

@atmorling atmorling commented Nov 28, 2024 •
edited
Loading

Closes #167
Closes #276

WIP

  • Removes some unnecessary ER IO
  • ER IO tests are now only run if relevant files are changed

@atmorling atmorling changed the title Test improvments Test improvements Nov 28, 2024
@atmorling
Copy link
Contributor Author

atmorling commented Nov 28, 2024 •
edited
Loading

setup-micromamba takes ~20-30s on ubuntu-latest and macos-latest but EIGHT MINUTES on windows-latest. Let's look into that with this change

@cisaacstern cisaacstern mentioned this pull request Dec 3, 2024
Merged
@atmorling atmorling merged commit fa2c6d2 into master Dec 4, 2024
5 checks passed
@atmorling atmorling deleted the test_overhaul branch December 4, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ER testing overhaul Use local data for non-IO unit tests
1 participant
@atmorling