Flip day/night ratio to night/day (#292)

wildlife-dynamics · Oct 14, 2024 · 9eee138 · 9eee138
1 parent 45aa020
commit 9eee138
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/ecoscope/analysis/astronomy.py b/ecoscope/analysis/astronomy.py
@@ -1,7 +1,8 @@
 import warnings
+
 import numpy as np
-import pyproj
 import pandas as pd
+import pyproj
 
 try:
     import astroplan
@@ -109,4 +110,4 @@ def get_daynight_ratio(traj, n_grid_points=150) -> pd.Series:
     day_distance += (day_night_df.dist_meters * i).sum()
     night_distance += ((1 - i) * day_night_df.dist_meters).sum()
 
-    return day_distance / night_distance
+    return night_distance / day_distance
diff --git a/tests/test_astronomy.py b/tests/test_astronomy.py
@@ -1,7 +1,8 @@
-import pyproj
 import pandas as pd
-from ecoscope.base import Trajectory
+import pyproj
+
 from ecoscope.analysis import astronomy
+from ecoscope.base import Trajectory
 
 
 def test_to_EarthLocation(movebank_relocations):
@@ -36,8 +37,8 @@ def test_daynight_ratio(movebank_relocations):
     trajectory = Trajectory.from_relocations(movebank_relocations)
     expected = pd.Series(
         [
-            2.212816,
-            0.656435,
+            0.451912,
+            1.523379,
         ],
         index=pd.Index(["Habiba", "Salif Keita"], name="groupby_col"),
     )