-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFCORE-7035]: YAML extension doesn't support ParallelBoot. #6225
base: main
Are you sure you want to change the base?
Conversation
742b7a4
to
9fa29d9
Compare
Core -> Full Integration Build 14010 outcome was FAILURE using a merge of 9fa29d9 Failed tests
|
Core -> WildFly Preview Integration Build 14083 outcome was FAILURE using a merge of 9fa29d9 Failed tests
|
controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java
Show resolved
Hide resolved
controller/src/main/java/org/jboss/as/controller/AbstractOperationContext.java
Show resolved
Hide resolved
...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java
Show resolved
Hide resolved
ParsedBootOp subOp = new ParsedBootOp(childOp, null); | ||
xmlOperations.put(subOp.getAddress(), subOp); | ||
if (op.handler instanceof ParallelBootOperationStepHandler) { | ||
parallelBootOp = new ParsedBootOp(op, op.handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means any previous value for 'parallelBootOp' is discarded unused.
I think this needs more test coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, not exactly we need to update the handler which can only happen in https://github.com/wildfly/wildfly-core/blob/main/controller/src/main/java/org/jboss/as/controller/ModelControllerImpl.java#L536
...oller/src/main/java/org/jboss/as/controller/persistence/yaml/YamlConfigurationExtension.java
Show resolved
Hide resolved
9fa29d9
to
292c5d2
Compare
…rtRequired on boot. * AbstractOperationContext is ignoring reloadRequired() and restartRequired() if isBooting() is returning true. Jira: https://issues.redhat.com/browse/WFCORE-7038 Signed-off-by: Emmanuel Hugonnet <[email protected]>
* Adding YAML subsystem operations to the ParallelOperationHandler. Jira: https://issues.redhat.com/browse/WFCORE-7035 Signed-off-by: Emmanuel Hugonnet <[email protected]>
292c5d2
to
d697170
Compare
Adding YAML subsystem operations to the ParallelOperationHandler.
Jira: https://issues.redhat.com/browse/WFCORE-7035