Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While using the available
includes
features some limitations were found when trying to exclude patterns (due toglob
). For example when using!
on a character group, each letter is ignored instead of the group:This will exclude
sub-project/F*
,sub-project/o*
,sub-project/o*
,sub-project/P*
, etc from being processed. This issue also causes significant toil when excluding multiple paths.Note: Different variations of using
!
has been considered but non has work so farWhat’s The Change ?
To get around this and not change how
includes
works,excludes
removed patterns and/or files from being processed.