-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #218: Respect composer lock #219
base: master
Are you sure you want to change the base?
Fix #218: Respect composer lock #219
Conversation
…s during package install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition was brought up during the refactor to support Composer 2 and bounced around a bit [1] [2].
if ($this->state->forceUpdate()) { | ||
// Force update mode so that new packages are processed rather | ||
// than just telling the user that composer.json and | ||
// composer.lock don't match. | ||
$installer->setUpdate(true); | ||
} else { | ||
$this->logger->log('You may need to manually run composer update to apply merge settings'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation:
if ($this->state->forceUpdate()) { | |
// Force update mode so that new packages are processed rather | |
// than just telling the user that composer.json and | |
// composer.lock don't match. | |
$installer->setUpdate(true); | |
} else { | |
$this->logger->log('You may need to manually run composer update to apply merge settings'); | |
} | |
if ($this->state->forceUpdate()) { | |
// Force update mode so that new packages are processed rather | |
// than just telling the user that composer.json and | |
// composer.lock don't match. | |
$installer->setUpdate(true); | |
} else { | |
$this->logger->log('You may need to manually run composer update to apply merge settings'); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs fixing at least...
We have tested this in quite a few scenarios and it's correctly respecting the intended functionality. Maybe @reedy if you could have a look please? |
if ($this->state->forceUpdate()) { | ||
// Force update mode so that new packages are processed rather | ||
// than just telling the user that composer.json and | ||
// composer.lock don't match. | ||
$installer->setUpdate(true); | ||
} else { | ||
$this->logger->log('You may need to manually run composer update to apply merge settings'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs fixing at least...
Hi @reedy thank you for your activity on this. Thank you! |
Respect composer lock, no update any packages during package install.