Skip to content
This repository has been archived by the owner on Oct 9, 2022. It is now read-only.

Support for LTLfLast. #21

Merged
merged 3 commits into from
Mar 7, 2020
Merged

Support for LTLfLast. #21

merged 3 commits into from
Mar 7, 2020

Conversation

cipollone
Copy link
Collaborator

Proposed changes

Small PR:

  • LTLfLast class added. Parsing supported.

Fixes

Fix for #19 . I think a complete support for End would also require changes for WeakNext and Next. I think we can leave that Unsupported.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

@cipollone
Support for LTLfLast.
379afae 
+ Now LTLf expressions can use Last symbol.
cipollone
cipollone commented Mar 6, 2020
View reviewed changes
flloat/ltlf.py Outdated Show resolved Hide resolved
cipollone
cipollone commented Mar 6, 2020
View reviewed changes
flloat/ltlf.py Outdated Show resolved Hide resolved
marcofavorito
marcofavorito approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cipollone cipollone requested a review from marcofavorito March 7, 2020 10:17
marcofavorito
marcofavorito approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@marcofavorito marcofavorito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cipollone cipollone merged commit faef451 into develop Mar 7, 2020
@cipollone cipollone deleted the ltl-termination branch March 7, 2020 15:01
@cipollone cipollone mentioned this pull request Mar 11, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcofavorito marcofavorito marcofavorito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipollone @marcofavorito