Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Feature Policy integration with Document Policy. #295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clelland
Copy link
Contributor

@clelland clelland commented Nov 6, 2020

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@clelland
Copy link
Contributor Author

clelland commented Nov 6, 2020

This would close #296

@annevk
Copy link
Member

annevk commented Nov 9, 2020

I'm not sure if @martinthomson's comment there implies implementer interest. Were there existing tests that need to be modified to address this? (Should Document Policy move to its own repository?)

@clelland
Copy link
Contributor Author

clelland commented Nov 9, 2020

That's fair; should I request an official position on MSP?

I figured that your comments here, here, 👍 here, and @martinthomson's comments and 👍 there were at least indicative of interest, and at least met the non-binding support mentioned in Changes (there aren't any descriptions of more formal processes there).

I'm happy to follow whatever process makes sense for WHATWG; in the meantime, I've removed the indication of support in the issue description.

Test changes to WPT are inbound; there are always chicken-and-egg issues with these things.

Moving Document Policy to its own repo is a better issue to raise with WebAppSec, I think, than here.

@martinthomson
Copy link

We're being very careful to distinguish between interest (lots of stuff is interesting) and outright support. If you want a clear indication of support then asking is best. Of course, if we've implemented something, feel free to interpret that as support in the absence of other signals, but those cases are usually fairly obvious.

@clelland
Copy link
Contributor Author

I think that what is asked for in the issue template (and what I figured I was responding to originally) is interest, but the working mode doc only mentions support, so I'm no longer sure what the criteria for checking the box there is.

If it needs a "we are planning on implementing this soon"-level-of-support, then certainly this PR can stay open until it gets there (if ever). I'm fine letting the box stay unchecked until we have whatever level of consensus is needed.

@annevk
Copy link
Member

annevk commented Nov 11, 2020

Sorry for the lack of clarity, what the WHATWG looks for is support in the sense of "should be part of the web platform" (roadmap matters a bit less, though in practice we look for at least one implementer having it on there). I don't think Firefox is there yet for Document Policy, though it's a better and more principled approach than what preceded it.

Base automatically changed from master to main January 15, 2021 07:39
sideshowbarker added a commit that referenced this pull request Mar 25, 2021
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 25, 2021
See whatwg/xhr#321:

> We should probably drop this section for now as it doesn't have
> multi-implementer interest.

Related: whatwg/xhr#295
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Mar 25, 2021
See whatwg/xhr#321:

> We should probably drop this section for now as it doesn't have
> multi-implementer interest.

Related: whatwg/xhr#295
Elchi3 pushed a commit to mdn/browser-compat-data that referenced this pull request Mar 25, 2021
See whatwg/xhr#321:

> We should probably drop this section for now as it doesn't have
> multi-implementer interest.

Related: whatwg/xhr#295
@annevk
Copy link
Member

annevk commented Mar 25, 2021

As an update, we're removing the Permissions Policy-based integration in #322. This can then be rebased for the Document Policy-based integration and merged when there's sufficient implementer support for Document Policy.

annevk pushed a commit that referenced this pull request Mar 26, 2021
Feature Policy is now known as Permissions Policy and sync-xhr is no longer part of it. It is now part of Document Policy. See #295 for follow-up work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants