Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland JSON module scripts #5658

Merged
merged 71 commits into from
Jul 29, 2021
Merged

Reland JSON module scripts #5658

Changes from 6 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
914e7d5
Reland JSON modules
dandclark Jun 17, 2020
b058240
Add import attribute type checks and initial plumbing.
dandclark Jun 18, 2020
d0137f5
Plumb through ModuleRequest instead of string for 'fetch an import() …
dandclark Jun 18, 2020
b2e7065
Don't cache a null entry in the module map in the case where the MIME…
dandclark Jun 18, 2020
0cbf597
Allow modulepreload to work for all module types without needing to s…
dandclark Jun 19, 2020
6932074
After rebase, fix build break from name change to JSON.Parse in https…
dandclark Jun 19, 2020
1f83c7e
Fix typo in JSON modules example and add note on requiring JSON MIME …
dandclark Jun 22, 2020
a3621dd
Update ModuleRequest definition to reference the import-attributes pr…
dandclark Jun 22, 2020
55ebd12
Revert added null check in 'fetch a modulepreload module script graph…
dandclark Jun 22, 2020
af41b28
Reference ParseJSONModule from import-attributes proposal instead of …
dandclark Jun 22, 2020
a2d4260
Cache an entry in the module map if the fetched module was valid but …
dandclark Jun 23, 2020
f79c01f
Extend note to be clear that the module must have no effect until a r…
dandclark Jun 23, 2020
7c900a1
When a valid MIME type is received that doesn't match the requested t…
dandclark Jun 25, 2020
55c9ed9
Wrap <p class=note> in <li> so it's not directly under an <ol>, which…
dandclark Jun 26, 2020
322808d
Whitespace change: remove double spaces after sentences in notes. Ho…
dandclark Jun 26, 2020
43e6fe3
Merge branch 'upstream-master' into dandclark/import-attributes
dandclark Jun 30, 2020
9f2ae27
Reword invocations of 'create a module script with matching type' to …
dandclark Jun 30, 2020
e86dd65
Change 'fetch a single module script' to fail if there are any unrec…
dandclark Jun 30, 2020
3318ed3
Instead of passing fetch response parameter to 'create a module scrip…
dandclark Jul 7, 2020
3c0dce2
Add assert that 'create a module script with matching type' is not ru…
dandclark Jul 7, 2020
1c9df5a
Reword caching comment
dandclark Jul 8, 2020
3247e99
Handle rename in TC39 proposal from import attributes to import condi…
dandclark Jul 9, 2020
dca376b
Update for the latest rename of the proposal from 'Import Conditions'…
dandclark Jul 24, 2020
e3359b5
Use module type as part of module map cache key instead of caching re…
dandclark Jul 27, 2020
0857ec8
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Aug 27, 2020
aafb256
Change 'abort these steps' to 'return' to match recent changes in 'fe…
dandclark Aug 27, 2020
9164acf
Remove JSON modules references, switch JavaScript module script refer…
dandclark Aug 28, 2020
9eda0e2
Properly return non-null module map entry if one already exists.
dandclark Aug 31, 2020
9fbbc6d
Update spec links to reflect split of import assertions and json modules
dandclark Aug 31, 2020
a8cb4a9
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Sep 30, 2020
f53c203
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Sep 30, 2020
1117dc3
Update module map dfn note to explain purpose of having module type i…
dandclark Sep 30, 2020
73f2be2
Update module map dfn note to explain purpose of having module type i…
dandclark Sep 30, 2020
eec60c5
Ignore unknown import assertions instead of failing. Continue failing…
dandclark Sep 30, 2020
6ed4474
Ignore unknown import assertions instead of failing. Continue failin…
dandclark Sep 30, 2020
c225d56
Move check for unknown type assertion to 'create a module script'.
dandclark Oct 5, 2020
2448342
Move check for unknown type assertion to 'create a module script'.
dandclark Oct 5, 2020
6a160fe
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Nov 11, 2020
1566bc0
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Nov 12, 2020
3c94b31
Review feedback: use tuple instead of pair, improve module map defini…
dandclark Nov 12, 2020
9da92b5
Review feedback: Link to memory cache issue, null --> 'javascript' ty…
dandclark Nov 13, 2020
26c2b81
Remove duplicated words
dandclark Nov 13, 2020
4ad7d2d
Move quotes outside of <code> elements.
dandclark Nov 16, 2020
614a9f4
Add HostGetSupportedAssertions integration
dandclark Nov 30, 2020
2fc3616
Fix indentation/spacing. Use short list notation.
dandclark Dec 1, 2020
697a6f1
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Dec 11, 2020
a9eed9b
Use two separate scripts in example so that at least one will actuall…
dandclark Dec 29, 2020
973ec71
Add module type to visited set.
dandclark Dec 29, 2020
337124e
Merge remote-tracking branch 'upstream/master' into dandclark/import-…
dandclark Dec 30, 2020
cf01c6d
Use two separate scripts in example so that at least one will actuall…
dandclark Dec 29, 2020
d954ad7
Add module type to visited set.
dandclark Dec 29, 2020
5bc28f6
Add HostGetSupportedAssertions integration
dandclark Nov 30, 2020
1b4da46
Fix indentation/spacing. Use short list notation.
dandclark Dec 1, 2020
eb8d82d
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark Dec 30, 2020
45f6c6e
Fix up some issues from merge
dandclark Dec 31, 2020
87eec91
Update visited set changes for json module type
dandclark Dec 31, 2020
fdc08f8
Clarify that memory cache mitigating violation of import assertions s…
dandclark Dec 31, 2020
a9f4d00
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark Dec 31, 2020
30e27fb
Merge remote-tracking branch 'upstream/main' into dandclark/import-at…
dandclark Mar 10, 2021
9ec7c7e
Add class='XXX' to note about the memory cache
dandclark Mar 11, 2021
9690560
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark Jun 24, 2021
f5f9ec1
Merge branch 'main' into dandclark/import-attributes-no-json
dandclark Jun 24, 2021
be37963
Merge branch 'dandclark/import-attributes-no-json' into dandclark/imp…
dandclark Jun 24, 2021
ab21bd5
Merge branch 'main' into dandclark/import-attributes
dandclark Jul 26, 2021
aa104e0
Fix spacing
dandclark Jul 26, 2021
64c523d
Delete duplicated example
dandclark Jul 26, 2021
54498ba
Restore updated comments about CSS/JSON module script definition
dandclark Jul 27, 2021
9de359a
Combine some paragraphs
dandclark Jul 27, 2021
d4f5bd0
Add missing closing tags
dandclark Jul 27, 2021
43526c4
Use CreateDefaultExportSyntheticModule for CSS module scripts
dandclark Jul 27, 2021
10af46b
Use not/or instead of neither/nor
dandclark Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading