Add Last-Event-ID to CORS-safelisted request headers
#1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoichio @KershawChang @youennf any final thoughts? |
annevk
reviewed
Nov 19, 2024
Since EventSource implementations in most environments already send this header without CORS preflight request, it makes sense to make it a safelisted header. See whatwg#568
rexxars
force-pushed
the
feat/cors-safelist-last-event-id
branch
from
76fc1a2
to
7a0ead3
Compare
Thanks! Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since EventSource implementations in most environments already send this header without CORS preflight request, it makes sense to make it a safe-listed header.
See #568 for more background.
Last-Event-IDto CORS-safelisted headers web-platform-tests/wpt#49257(See WHATWG Working Mode: Changes for more details.)
Preview | Diff