Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

feat: create MetaMaskSDKConnector using @metamask/sdk #422

Closed
wants to merge 12 commits into from

Conversation

abretonc7s
Copy link
Collaborator

@abretonc7s abretonc7s commented Jul 12, 2023

Description

Add MetaMask SDK integration to allow MetaMask mobile wallet users to connect.

Additional Information

  • [ x ] I read the contributing docs (if this is your first contribution)
  • switch between browser extension and mobile wallet
  • Kept metamask connector for backward compatibility and staged user migration

Your ENS/address: 0x5Cba62cA5F5C47d39943f38b2047B90bFfA41cd9

Demo

wagmi_demo

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: 3dcd9e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/connectors Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

socket-security bot commented Jul 12, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@socket-security
Copy link

socket-security bot commented Jul 12, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@abretonc7s abretonc7s marked this pull request as ready for review July 24, 2023 06:13
@abretonc7s abretonc7s marked this pull request as draft July 24, 2023 10:09
@abretonc7s abretonc7s marked this pull request as ready for review July 24, 2023 10:13
@abretonc7s abretonc7s changed the title feat: create MetaMaskSDKConnector using @metamask/sdk 0.5.0 feat: create MetaMaskSDKConnector using @metamask/sdk Jul 24, 2023
@abretonc7s abretonc7s closed this Jul 25, 2023
@abretonc7s abretonc7s reopened this Jul 25, 2023
@abretonc7s
Copy link
Collaborator Author

@SocketSecurity ignore @metamask/sdk

@abretonc7s abretonc7s closed this Jul 25, 2023
@abretonc7s abretonc7s reopened this Jul 31, 2023
@abretonc7s abretonc7s requested review from tmm and jxom July 31, 2023 15:01
@tmm
Copy link
Member

tmm commented Aug 31, 2023

Appreciate the effort that went into this! We've been busy with other work so haven't had time to support new connectors. We are reworking how connectors are setup (directly in the wagmi repo instead of references, new API, etc.) so once that is done this can be created again. Stayed tuned to the wagmi discussion board for more info.

In the meantime, I would suggest releasing this as it's own package so folks can install and use directly from there.

@tmm tmm closed this Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants