Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds CSS proposal to the project root for commenting purposes #14

Merged
merged 1 commit into from
Dec 7, 2021
Merged

adds CSS proposal to the project root for commenting purposes #14

merged 1 commit into from
Dec 7, 2021

Conversation

duboisp
Copy link
Member

@duboisp duboisp commented Dec 30, 2019 •
edited
Loading

duboisp
duboisp commented Dec 30, 2019
View reviewed changes
Copy link
Member Author

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the CSS variable approach.

gc-design-system-variable-proposal.css Show resolved Hide resolved
gc-design-system-variable-proposal.css Show resolved Hide resolved
@duboisp duboisp merged commit e75aa85 into wet-boew:master Dec 7, 2021
@duboisp duboisp mentioned this pull request Dec 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delisma delisma delisma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duboisp @delisma @JoshBeveridge