Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsers: whois.cira.ca: Add new version support for 2019 whois output #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XaF
Copy link

@XaF XaF commented Nov 7, 2019

Most recent whois output from CIRA, with year 2019, has a very different
output than what was expected in the past. This adds support for it
while keeping support for previous versions of the whois output.

This requires the changes introduced in PR #130 to work properly (as issue with the missing new line otherwise).

Fixes #126

Most recent whois output from CIRA, with year 2019, has a very different
output than what was expected in the past. This adds support for it
while keeping support for previous versions of the whois output.
@XaF XaF requested a review from weppos February 19, 2020 14:52
@weppos weppos removed their request for review February 20, 2020 09:51
@joallard
Copy link

Looking good! Fixes #126.

@ericgascoine
Copy link

I'm finding that this fix is needed for the .ca domains.

If we're not comfortable with the fix in #130, Is it possible to move the fix for the unterminated (with newline lines into the parser (lib/whois/parsers/whois.cira.ca.rb) with something like:

      def content_for_scanner
        super
        @content_for_scanner << "\n" unless @content_for_scanner.end_with?("\n")
        @content_for_scanner
      end

How can we move this PR forward?

@XaF
Copy link
Author

XaF commented Jul 14, 2020

I just answered to @joallard on #130 to have this move forward.
Who has merge rights on this repository though ?

@jarthod
Copy link

jarthod commented Nov 25, 2021

Thanks for this @XaF, for the record I ended up starting my fork in which I merged some of the pending PRs and provided more fixes. I didn't cherry-pick your PR here because it was keeping a lot of legacy code and adding on top, instead I refactored the parser to use the standard ICANN Compliant parser and updated all tests in ed7068c. There's no reason to keep supporting the outdated version (unless you see one?), whois.cira.ca server is not going to return older versions any more. This version is working well for the couple hundreds of .ca domains I have. So people who need this can use my fork in the meantime:

gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.ca whois issue
4 participants