Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/wenqi/fix codecov token #8

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wenqiq
Copy link
Owner

@wenqiq wenqiq commented Sep 24, 2024

No description provided.

wenqiq and others added 6 commits September 20, 2024 10:20
Fix the nil pointer dereference panic issue

Update `EdgeClusterEnabled` function and add a cover unit test case

Signed-off-by: Wenqi Qiu <[email protected]>
Previsouly, we use hyphen "-" to connect strings when building NSX resource
name, and use underline "_" to connect strings when builindg NSX
resource ID.

This patch is to unify NSX resource ID and name connecotr as underline when building
ID and name from K8s CR.

For the NSX resoruce ID and name convention,
this patch is follow the standard in PR:vmware-tanzu#643

These NSX resources name are impacted in this change:
VPC
Subnet
SubnetPort
SecurityPolicy and NetworkPolicy
NSGroup and IPSetGroup
NSRule
Share
StaticRoute
IPAllocation

This patch is aslo to add two flags for GC and vpcCleanup in order to
distinguish these two cases.
Integrate Codecov into CI pipeline
Uploaded coverage to Codecov
Viewed coverage reports in pull requests

Signed-off-by: Wenqi Qiu <[email protected]>
Signed-off-by: Wenqi Qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants