Remove Subnet Finalizer #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the nil pointer dereference panic issue Update `EdgeClusterEnabled` function and add a cover unit test case Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
2 times, most recently
from
b69b21e to
1652a33
Compare
Previsouly, we use hyphen "-" to connect strings when building NSX resource name, and use underline "_" to connect strings when builindg NSX resource ID. This patch is to unify NSX resource ID and name connecotr as underline when building ID and name from K8s CR. For the NSX resoruce ID and name convention, this patch is follow the standard in PR:vmware-tanzu#643 These NSX resources name are impacted in this change: VPC Subnet SubnetPort SecurityPolicy and NetworkPolicy NSGroup and IPSetGroup NSRule Share StaticRoute IPAllocation This patch is aslo to add two flags for GC and vpcCleanup in order to distinguish these two cases.
Signed-off-by: Yanjun Zhou <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
from
f407519 to
7c8d783
Compare
Integrate Codecov into CI pipeline Uploaded coverage to Codecov Viewed coverage reports in pull requests Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
2 times, most recently
from
927826a to
aa23e65
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
The private ipblocks in VPC are now maintained by nsx, nsx operator will not do operations on these nsx resources, so vpc service do not need to build its store anymore. Remove the private ip blocks store and its related logics.
Signed-off-by: Wenqi Qiu <[email protected]>
The cleanup command, it's called by wcpsvc as a lib. Wcpsvc may call have multiple cleanup instances. The tokenProvider should have no global cache when LibMode is true Remove tokenProvider cache for clean
Remove private ip block store in VPC
…nzu#770) Subnetport/pod controller will acquire a subnet, create nsx subnetport on it and save the subnetport to store after it is created. But Subnetset GC may delete the subnet during the subnetport creation The PR adds locks for subnet by subnet path to avoid this race condition. Testing done: Decreased the subnetset garbage collector running interval to 10 seconds to increase the potential of race. Created 8 pods, waited for all related subnetports created without error and delete the pods. Repeated for 5 times and not found deadlock or race issue. Signed-off-by: Yanjun Zhou <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
from
aa23e65 to
251eb16
Compare
Based on new NSX VPC 2.0 API, we need to use below request body to create NSX subnet:
{
"id": "subnet-1",
"resource_type": "VpcSubnet",
"display_name": "Subnet 1",
"description": "This is test VpcSubnet",
"access_mode": "Private",
"ipv4_subnet_size":64,
"dhcp_config": {
"enable_dhcp": false
},
"_revision": 0
}
…subnet Build Subnet DHCPConfig with new NSX VPC 2.0 API
Create new tokenProvider for cleanup command
Signed-off-by: Xie Zheng <[email protected]>
Signed-off-by: Yanjun Zhou <[email protected]>
Add unit test for ipaddressallocation
Signed-off-by: Yanjun Zhou <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
2 times, most recently
from
a74cabd to
0fbef86
Compare
Per FSS enable requirement, UT coverage should be over 70%.
Add UT test for VPC service
In VPC creation procedure, if nsx vpc is created but failed to realize, it is not insert into vpc store, so in vpc deletion method if vpc is not found in store, it should also return OK.
Do not check cache when deleting unrealized vpc
NSX does not support change either from static IP Allocation to DHCP or from DHCP to static IP Allocation. This PR updates the Subnet/SubnetSet CRD to make DHCPConfig immutable; and also - Prevent all the immutable fields in Subnet/SubnetSet from being updated from a value to empty - Fixes a bug in subnet update to inherit other fields from the existing Subnet to avoid overriding some immutable fields like IP Addresses and IP Blocks by empty during the update. Signed-off-by: Yanjun Zhou <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
2 times, most recently
from
da8e495 to
633087f
Compare
Signed-off-by: Yanjun Zhou <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
5 times, most recently
from
f5ac307 to
1629917
Compare
Remove SubnetSet Finalizer Add unit-test for Subnet controller Signed-off-by: Wenqi Qiu <[email protected]> Signed-off-by: Wenqi Qiu <[email protected]>
wenqiq
force-pushed
the
topic/wenqi/rm-subnet-finalizer
branch
from
c390e0d to
0f72d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.