Add data-gtm-trigger for popular_story #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
gestchild
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The classes that styled-components generates doesn't give us anything sensible to hook onto for a tagmanager trigger. We've used a data-attribute for this in the past –
data-gtm-trigger={x}, so reusing that principle here.How to test
View a story with the recommended stories toggle turned on and verify the
data-gtm-trigger="popular_story"attribute is added to the containinglielements for each recommended story cardHow can we measure success?
We can use tagmanager to measure events
Have we considered potential risks?
n/a