-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds toggle for concepts by ID work #11413
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcantin-w
approved these changes
Nov 19, 2024
Size Change: 0 B Total Size: 996 kB ℹ️ View Unchanged
|
kenoir
force-pushed
the
rk/add-concepts-toggle
branch
from
November 19, 2024 15:18
4f99d77
to
5b462aa
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Part of wellcomecollection/platform#5654
Follows wellcomecollection/catalogue-api#830
This change adds a toggle to be used in front-end work to use an implementation of concepts pages and search filters that use concept IDs rather than labels.
How to test
yarn deploy
, does the toggle appear?How can we measure success?
Gracefully working on updating concept pages without changing what the public sees.
Have we considered potential risks?
This change only adds the toggle (which is off by default), so risk should be minimal.