Allow for Vimeo vids in VideoEmbed
#11412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -10.5 kB (-1.04%) Total Size: 996 kB
ℹ️ View Unchanged
|
kenoir
reviewed
Nov 19, 2024
| @@ -10,6 +10,8 @@ import PrismicHtmlBlock from '@weco/common/views/components/PrismicHtmlBlock/Pri | |||
|
|
|||
| export type Props = { | |||
| embedUrl: string; | |||
| videoProvider?: string; | |||
There was a problem hiding this comment.
Can you constrain this type further?
| hasFullSizePoster ? 'maxresdefault' : 'hqdefault' | ||
| }.jpg` | ||
| : isVimeo | ||
| ? videoThumbnail |
There was a problem hiding this comment.
I did! But I wasn't sure we wanted to use some third party for this..? There's also this that could be worth a look https://github.com/vimeo/vimeo-oembed-examples ..
davidpmccormick
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#11408
Our slices allowed for
YoutubeandVimeoin that it would still treat it in the Body transformer, but once you got toVideoPlayer, it was strictly Youtube. This is probably due to the fact that we haven't had a Vimeo video in the time I've been here (So around 2 and a half years at a minimum).With the problems we're currently experiencing with YT, we'd like to go back to supporting Vimeo.
So this ticket:
VideoEmbed/VideoPlayermore flexible; now passing invideoProvider(for easier conditionals) &videoThumbnail(for the Vimeo Thumbnail)hcontent/webapp/services/prismic/transformers/exhibition-highlight-tours.tscontent/webapp/services/prismic/transformers/exhibition-guides.tsas well, which supports legacy EG.There are a few TODOs in the code now, they're up for conversation with whoever reviews this/might be done as a later task (if so I will tidy and create new tickets), to prioritise just rendering those videos.
How to test
Run locally with Prismic staging API
How can we measure success?
Renders YT and Vimeo successfully
Have we considered potential risks?
If doubled QA'd, should be low risk