-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop unicode characters printing to page #11392
Conversation
Do we know why this fixes it? Why did it suddenly show it after 18 months? 😅 Wonder if it's some update with styled-components. |
Size Change: +12 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming it was because of one of the upgrades. When I moved the encodeing to a const eslint complained about octal escape sequences are not being allowed, so I needed to escape it to turn it into a string. Then it started working. |
What does this change?
As reported on Slack the unicode encoding we used for on breaking spaces in Tags was being displayed, rather than just the space itself.
This fixes that
How to test
Visit localhost:3000/works/tgzf7p3n and see that this doesn't happen
How can we measure success?
the tags display as expected
Have we considered potential risks?
Low