Stories page articles from Content API #11387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: +439 B (+0.04%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
davidpmccormick
changed the base branch from
main
to
content-api-homepage-stories
gestchild
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Gets the stories page articles from the Content API
How to test
Visit
/storiesand check the five stories at top of the page and the six stories under the 'You may have missed' header at the bottom of the page all render.(This change reinstates the comics alongside the other stories in the result lists, so there is an expected difference between the results here and what's in prod).
How can we measure success?
We're less reliant on Prismic
Have we considered potential risks?
If we had needed to replicate what is currently in prod, it would have been tricky with the Content API currently, because while you can filter (e.g. all articles that are comics), you can't do a negated filter (e.g. all articles that aren't comics). Will make a note of this as something to bear in mind