Articles > stories URL changes #11325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5.63 kB (-0.57%) Total Size: 979 kB
ℹ️ View Unchanged
|
|
@LaurenFBaily would appreciate your thoughts on how this might affect our analytics data and if we need to do anything/let anyone know before this is deployed |
|
Yes it will (again) affect analytics but Grace is aware of the impact. It essentially means that to look at the analytics for a single article created before this change is deployed it will have the traffic split across three different urls. This will matter less as time goes on. |
|
thanks, I guess we just need to note the date of the deployment then. In the days of UA we could add a note inside GA, don't know if there is an equivalent nowadays |
rcantin-w
reviewed
Oct 28, 2024
rcantin-w
approved these changes
Oct 29, 2024
yeah, I'm doing the redirects in the app here, so we can deploy them with the code changes so that nothing breaks. Then will move then to redirects.ts in a subsequent PR |
8 tasks
# Conflicts: # common/services/prismic/link-resolver.test.ts
|
Changes deployed on 29/10/2024 about 13:35 - added to Notion Doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For #11071
These redirects are temporarily done in the next.config.js file. This means we can deploy the code and redirects at the same time and nothing will break. Once this is live, I'll move the redirects to the lambda function we use for all the other redirects and remove these ones.
Also adds hotjar script for stories pages, see: #11331
Questions:
is it ok to point /stories/comic to /search/stories filtered by comic?-yeswas anything else being served at /stories/:customType?- nodon't like having the redirects in more than one place. Can/should we use the redirection lambda rather than next config redirects?- yes, but temporarily use these so nothing breaksdo we need to update the literalRedirects that point to articles/:uid?- yes, as part of the lambda workHow to test
You will also be able to see the 301 redirects in the network tab of the developer toolbar.
How can we measure success?
We serve pages at /stories/:uid rather than /articles:uid
Have we considered potential risks?
Will there be an impact on Analytics data?