Revert "Trial Prismic's next preview tool, part II" #10788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -3.2 kB (0%) Total Size: 950 kB
ℹ️ View Unchanged
|
|
Although shareable links don't work locally with this implementation we've decided to go ahead and get it in production to see if it works there. There is no perfect solution at the moment but we'd rather not load the Prismic Preview Next tool's script for all users. If we're still struggling with previews being shared, then we can look a bit more closely at our implementation and if anything needs fixing. Worth repeating that Prismic will need to look at their third-party cookie solution soon as less and less browsers allow it by default (there are threads on their forums regarding it but no update). |
davidpmccormick
approved these changes
Apr 18, 2024
rcantin-w
deleted the
revert-10740-revert-10739-revert-10721-next-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10740 - apologies for the amount of reverts, but we've now tested Prismic's Next Preview toolbar in production, and it does work, but... what also happens is that the script loads for all users (in order to get the shareable link to work), which causes performance issues, loads jQuery for all and flags an a11y miss in pa11y (no title on the iframe element). Having read through an issue that was raised 5 years ago, it's been a thing for a long time and it doesn't look like it'll be fixed any time soon, so we've decided to revert back to our previous solution.
Slack chat here for decision making and here for how we detected the issue (pa11y!).