Remove TODO and add thumbnail to Embed slice

wellcomecollection · Nov 19, 2024 · bfce97e · bfce97e
1 parent 32a62e0
commit bfce97e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/common/views/components/VideoEmbed/VideoEmbed.tsx b/common/views/components/VideoEmbed/VideoEmbed.tsx
@@ -71,10 +71,6 @@ const VideoEmbed: FunctionComponent<Props> = ({
   const isVimeo = videoProvider === 'Vimeo';
 
   useEffect(() => {
-    // TODO do we need analytics consent for vimeo?
-    // Do we need this?
-    /* <script src="https://player.vimeo.com/api/player.js"></script> */
-
     if (isYouTube && hasAnalyticsConsent) {
       // GA4 automatically tracks YouTube engagement, but requires the iframe api
       // script to have been loaded on the page. Since we're lazyloading youtube

diff --git a/content/webapp/services/prismic/transformers/body.ts b/content/webapp/services/prismic/transformers/body.ts
@@ -338,8 +338,8 @@ export function transformEmbedSlice(
       value: {
         embedUrl: getVimeoEmbedUrl(embed),
         videoProvider: 'Vimeo',
-        // TODO? Do we want to support it on legacy guides?
-        // videoThumbnail
+        videoThumbnail:
+          (embed.thumbnail_url_with_play_button as string) || undefined,
         caption: slice.primary.caption,
         transcript: slice.primary.transcript,
       },