Use Common Runtime Libraries in S3TransferManager #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
commented
Apr 9, 2024
| ports: | ||
| - "10000:10000" | ||
| command: ["azurite", "--blobHost", "0.0.0.0"] | ||
| version: "3.3" |
There was a problem hiding this comment.
Needed to update this to run with my version of docker, think that will be the case for anyone wanting to run this.
|
Closing as this doesn't change the implementation (the default behaviour is this hidden in the s3 transfer manager builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change attempts to make use of the Common Runtime Libraries for the AWS SDK intended to improve performance.
We include them as a dependency but do not use them in the
S3TransferManagerwhere we do large transfers. The documentation describes how to do this.The intention is to improve the performance of the replicators which are currently showing issues transferring large files to S3.
How to test
How can we measure success?
Improved performance, less failures.
Have we considered potential risks?
This will impact replication performance, hopefully only positively but there are could be negative impacts.