-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Content for v2.4.1 #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### TL;DR Updated the Slack notification message in the GitHub workflow to format the `helm upgrade` command as a code block and to include the package path in the footer. ### What changed? - Changed `SLACK_MESSAGE` to format the `helm upgrade` command as a code block. - Updated `SLACK_FOOTER` to include the package path. ### How to test? Trigger a workflow run and verify the Slack notification format and content. ### Why make this change? Improving readability and context of Slack notifications. ---
fix(CSI-234): leak of wekafs mounts due to bad IsMounted() check
fix(CSI-224,WEKAPP-417375): race condition on multiple volume deletion in parallel
fix(CSI-236): for OCP installations, only 1 machineConfigPolicy was created
Allowed by better multithreaded offline deletion process
fix(CSI-237): increase parralelism of PV deletions
### TL;DR This change introduces an additional scope 'WEKAPP-\d+' to the PR title linting configuration in our GitHub workflow. This ensures that PR titles can include the WEKAPP identifier. ### What changed? - Updated the lint_pr.yaml file to recognize and accept 'WEKAPP-\d+' as a valid scope in PR titles. ### How to test? - Create a PR with 'WEKAPP-xxx' in the title and verify that the linting workflow does not flag it as invalid. ### Why make this change? This update is necessary to allow PRs that include WEKAPP identifiers in their title, facilitating better tracking and categorization of tasks related to the WEKAPP project. ---
### TL;DR This PR adds validation functions to check for valid IPv4, IPv6 addresses, and hostnames in the `resetDefaultEndpoints` method and skips endpoints that do not pass validation. ### What changed? - Introduced `isValidIPv4Address`, `isValidIPv6Address`, and `isValidHostname` functions. - Updated the `resetDefaultEndpoints` method to utilize these validation functions and skip invalid endpoints. ### How to test? - Add unit tests to check validation functions with various inputs. - Test CSI plugin basic sanity in IPv6-enabled Kubernetes cluster against IPv6-only Weka cluster (install, create PVC, create pod) ### Why make this change? - This change ensures that IPv6 addresses can be specified in configuration ---
### TL;DR This pull request introduces a conditional configuration to enable `hostNetwork` support for the `csi-wekafsplugin` Helm chart. The changes involve adding conditional checks in the templates to apply the `hostNetwork` settings based on the values provided. ### What changed? - Added conditional statements to `controllerserver-statefulset.yaml` and `nodeserver-daemonset.yaml` to apply `hostNetwork` settings. - Updated security context constraints templates to allow host networking when the `hostNetwork` value is true. - Modified port numbers in the `nodeserver-daemonset.yaml` to accommodate the `hostNetwork` setup. ### How to test? 1. Set `hostNetwork: true` in the `values.yaml` file. 2. Deploy the Helm chart. 3. Verify that the necessary resources are deployed with the `hostNetwork` configuration. ### Why make this change? This change is motivated by the need to support host networking for specific environments where pod networking might be insufficient or problematic, such as Weka clusters running on top of Kubernetes. Allowing conditional `hostNetwork` configuration provides greater flexibility and control over the networking setup of the CSI driver components.
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/31/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.