Skip to content

Commit

Permalink
Merge pull request kubernetes#33133 from mml/omg-loop-variables
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

Stop referring to loop variable inside closure.

Prior to this, I was actually running the same (last) test 5 times in a row.  :-(

Fixes kubernetes#33137
  • Loading branch information
Kubernetes Submit Queue authored Sep 21, 2016
2 parents 0986a01 + f2ab87b commit cfecc2f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/e2e/disruption.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ var _ = framework.KubeDescribe("DisruptionController", func() {
shouldDeny: true,
},
}
for _, c := range evictionCases {
for i := range evictionCases {
c := evictionCases[i]
expectation := "should allow an eviction"
if c.shouldDeny {
expectation = "should not allow an eviction"
Expand Down

0 comments on commit cfecc2f

Please sign in to comment.