Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[minor] Remove history file. All this information can be extracted us…
…ing git diff's The history.md is maintaince burden that is unneeded. The changes can seen by comparing the git tags. `git log tag1..tag2` is your friend.
- Loading branch information
d32c678There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strong disagreement about changelogs being unnecessary.
I always looked at this file while updating this dependency. As I'm not a contributor to this project I don't even have a ws checkout to run git log on.
d32c678There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can compare it just as easy on github: 0.6.4...0.6.5. The history file does not have any significant value other than listing git commits which were in the release.
d32c678There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree; a well-written changelog communicates just what you need to know when considering updating your dependencies. Full git log on the other hand contains a lot of unnecessary details.
Consider that not every commit needs to go on the changelog.
d32c678There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eagleflo 👍
d32c678There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to meet you guys half way, i'm moving change log to github releases. So each release wil have a burp of context in the https://github.com/einaros/ws/releases page.