-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run pytest directly. setup.py test was removed in setuptools 72. #172
Run pytest directly. setup.py test was removed in setuptools 72. #172
Conversation
Hm. Code coverage is not currently working, which makes it difficult to properly test this PR. |
There is coverage output in the logs: https://github.com/webrecorder/warcio/actions/runs/10406578911/job/28991147343?pr=172#step:7:337
|
On master it is currently: https://github.com/webrecorder/warcio/actions/runs/10468183347/job/28988504338#step:6:364
|
The only difference is:
While I don't get the value for faster, since the new test for version was introduced in 29da916. The coverage stays the same resp. has increased for |
Thank you, perfect, I should have looked more carefully at the logs. |
Run pytest directly. setup.py test was removed in setuptools 72.
https://setuptools.pypa.io/en/latest/history.html#v72-0-0
Derived from #169 . Lets split it into portions.