Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved locking performance on .NET 9.0+ #685

Open
wants to merge 238 commits into
base: development
Choose a base branch
from

Conversation

MarkCiliaVincenti
Copy link

The new System.Threading.Lock offers greater performance, as independent benchmarks show (eg https://steven-giesel.com/blogPost/4cf6d48a-ec9d-4c68-961c-31fd8d8c1340)

@CLAassistant
Copy link

CLAassistant commented Sep 1, 2024

CLA assistant check
All committers have signed the CLA.

@webprofusion-chrisc
Copy link
Contributor

Thanks Mark! We don't typically struggle with lock performance but we'll definitely consider integrating this for modernity, the backported dependency is potentially a little risky for us as all of our users are currently on net462 builds but we'll see.

Package updates

Package updates

Package updates

Package updates
@MarkCiliaVincenti
Copy link
Author

MarkCiliaVincenti commented Nov 30, 2024

Are you still interested in this @webprofusion-chrisc? In the meantime, the library can now be used as a source generator so that you do not add an external dependency.

@MarkCiliaVincenti
Copy link
Author

@webprofusion-chrisc would you like the source generator version?

@webprofusion-chrisc
Copy link
Contributor

Hi Mark we'll definitely consider this for next year and yes a source generator would be preferable to a run-time library dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants