Use type names when possible #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
typeless
branch
4 times, most recently
from
4024b7d
to
c988bb8
Compare
|
@spawnia Although the php-cs-fixer bot is super nice, the fact that it runs as a GitHub Actions causes it to not trigger the CI workflows. It can only be done like that when you use a Personal Access Token. |
Instead of calling Type::builtInTypes which calls Introspection::getTypes() that creates a lot of objects, we only need the type names.
|
@spawnia It's green now! |
|
Nice one. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling Type::builtInTypes which calls Introspection::getTypes() that creates a lot of objects, we only need the type names.
I noticed this while working on something else and I think this is a good improvement.