Improve unit tests

webeweb · Sep 4, 2019 · e5bd424 · e5bd424
1 parent 69b112a
commit e5bd424
Show file tree

Hide file tree

Showing 13 changed files with 67 additions and 72 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 CHANGELOG
 =========
 
+### [3.3.2](https://github.com/webeweb/bootstrap-bundle/tree/v3.3.2) (2019-09-04)
+
+- Improve unit tests
+
 ### [3.3.1](https://github.com/webeweb/bootstrap-bundle/tree/v3.3.1) (2019-07-22)
 
 - Add PHP extensions into Composer

diff --git a/Tests/Controller/LayoutControllerTest.php b/Tests/Controller/LayoutControllerTest.php
@@ -44,25 +44,7 @@ public function testBlankAction() {
      */
     public function testFlashbagAction() {
 
-        $res = <<< EOT
-            <div class="alert alert-danger alert-dismissible" role="alert">
-            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-            Danger
-        </div>
-                <div class="alert alert-info alert-dismissible" role="alert">
-            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-            Info
-        </div>
-                <div class="alert alert-success alert-dismissible" role="alert">
-            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-            Success
-        </div>
-                <div class="alert alert-warning alert-dismissible" role="alert">
-            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-            Warning
-        </div>
-    
-EOT;
+        $res = file_get_contents(__DIR__ . "/testFlashbagAction.html.txt") . "    ";
 
         // Create a client.
         $client = static::createClient();

diff --git a/Tests/Controller/testFlashbagAction.html.txt b/Tests/Controller/testFlashbagAction.html.txt
@@ -0,0 +1,16 @@
+            <div class="alert alert-danger alert-dismissible" role="alert">
+            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
+            Danger
+        </div>
+                <div class="alert alert-info alert-dismissible" role="alert">
+            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
+            Info
+        </div>
+                <div class="alert alert-success alert-dismissible" role="alert">
+            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
+            Success
+        </div>
+                <div class="alert alert-warning alert-dismissible" role="alert">
+            <button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
+            Warning
+        </div>
diff --git a/Tests/Twig/Extension/Component/BreadcrumbTwigExtensionTest.php b/Tests/Twig/Extension/Component/BreadcrumbTwigExtensionTest.php
@@ -53,13 +53,8 @@ public function testBootstrapBreadcrumbsFunction() {
 
         $obj = new BreadcrumbTwigExtension($this->twigEnvironment, $this->translator);
 
-        $res = <<< EOT
-<ol class="breadcrumb">
-<li><a href="javascript:void(0);">GitHub</a></li>
-<li class="active">Bootstrap bundle</li>
-</ol>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapBreadcrumbsFunction([], $this->tree, Request::create("https://github.com/webeweb/bootstrap-bundle")));
+        $res = file_get_contents(__DIR__ . "/testBootstrapBreadcrumbsFunction.html.txt");
+        $this->assertEquals($res, $obj->bootstrapBreadcrumbsFunction([], $this->tree, Request::create("https://github.com/webeweb/bootstrap-bundle")) . "\n");
     }
 
     /**

diff --git a/Tests/Twig/Extension/Component/ButtonGroupTwigExtensionTest.php b/Tests/Twig/Extension/Component/ButtonGroupTwigExtensionTest.php
@@ -65,13 +65,8 @@ public function testBootstrapButtonGroupBasicFunction() {
         $obj = new ButtonGroupTwigExtension($this->twigEnvironment);
 
         $arg = [];
-        $res = <<< EOT
-<div class="btn-group" role="group">
-<button class="btn btn-default" type="button">Edit</button>
-<button class="btn btn-danger" type="button">Delete</button>
-</div>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapButtonGroupBasicFunction($arg, [$this->editButton, $this->deleteButton]));
+        $res = file_get_contents(__DIR__ . "/testBootstrapButtonGroupBasicFunction.html.txt");
+        $this->assertEquals($res, $obj->bootstrapButtonGroupBasicFunction($arg, [$this->editButton, $this->deleteButton]) . "\n");
     }
 
     /**
@@ -84,13 +79,8 @@ public function testBootstrapButtonGroupToolbarFunction() {
         $obj = new ButtonGroupTwigExtension($this->twigEnvironment);
 
         $arg = [];
-        $res = <<< EOT
-<div class="btn-toolbar" role="toolbar">
-<button class="btn btn-default" type="button">Edit</button>
-<button class="btn btn-danger" type="button">Delete</button>
-</div>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapButtonGroupToolbarFunction($arg, [$this->editButton, $this->deleteButton]));
+        $res = file_get_contents(__DIR__ . "/testBootstrapButtonGroupToolbarFunction.html.txt");
+        $this->assertEquals($res, $obj->bootstrapButtonGroupToolbarFunction($arg, [$this->editButton, $this->deleteButton]) . "\n");
     }
 
     /**

diff --git a/Tests/Twig/Extension/Component/NavTwigExtensionTest.php b/Tests/Twig/Extension/Component/NavTwigExtensionTest.php
@@ -55,14 +55,8 @@ public function testBootstrapNavsJustified() {
         $obj = new NavTwigExtension($this->twigEnvironment);
 
         $arg = ["items" => $this->items];
-        $res = <<< EOT
-<ul class="nav nav-justified">
-<li role="presentation"><a href="#">Home</a></li>
-<li role="presentation"><a href="#">Profile</a></li>
-<li role="presentation"><a href="#">Message</a></li>
-</ul>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapNavsJustified($arg));
+        $res = file_get_contents(__DIR__ . "/testBootstrapNavsJustified.html.txt");
+        $this->assertEquals($res, $obj->bootstrapNavsJustified($arg) . "\n");
     }
 
     /**
@@ -75,14 +69,8 @@ public function testBootstrapNavsPills() {
         $obj = new NavTwigExtension($this->twigEnvironment);
 
         $arg = ["items" => $this->items, "stacked" => true];
-        $res = <<< EOT
-<ul class="nav nav-pills nav-stacked">
-<li role="presentation"><a href="#">Home</a></li>
-<li role="presentation"><a href="#">Profile</a></li>
-<li role="presentation"><a href="#">Message</a></li>
-</ul>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapNavsPills($arg));
+        $res = file_get_contents(__DIR__ . "/testBootstrapNavsPills.html.txt");
+        $this->assertEquals($res, $obj->bootstrapNavsPills($arg) . "\n");
     }
 
     /**
@@ -95,14 +83,8 @@ public function testBootstrapNavsPillsWithItems() {
         $obj = new NavTwigExtension($this->twigEnvironment);
 
         $arg = ["items" => $this->items];
-        $res = <<< EOT
-<ul class="nav nav-pills">
-<li role="presentation"><a href="#">Home</a></li>
-<li role="presentation"><a href="#">Profile</a></li>
-<li role="presentation"><a href="#">Message</a></li>
-</ul>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapNavsPills($arg));
+        $res = file_get_contents(__DIR__ . "/testBootstrapNavsPillsWithItems.html.txt");
+        $this->assertEquals($res, $obj->bootstrapNavsPills($arg) . "\n");
     }
 
     /**
@@ -115,14 +97,8 @@ public function testBootstrapNavsTabs() {
         $obj = new NavTwigExtension($this->twigEnvironment);
 
         $arg = ["items" => $this->items];
-        $res = <<< EOT
-<ul class="nav nav-tabs">
-<li role="presentation"><a href="#">Home</a></li>
-<li role="presentation"><a href="#">Profile</a></li>
-<li role="presentation"><a href="#">Message</a></li>
-</ul>
-EOT;
-        $this->assertEquals($res, $obj->bootstrapNavsTabs($arg));
+        $res = file_get_contents(__DIR__ . "/testBootstrapNavsTabs.html.txt");
+        $this->assertEquals($res, $obj->bootstrapNavsTabs($arg) . "\n");
     }
 
     /**

diff --git a/Tests/Twig/Extension/Component/testBootstrapBreadcrumbsFunction.html.txt b/Tests/Twig/Extension/Component/testBootstrapBreadcrumbsFunction.html.txt
@@ -0,0 +1,4 @@
+<ol class="breadcrumb">
+<li><a href="javascript:void(0);">GitHub</a></li>
+<li class="active">Bootstrap bundle</li>
+</ol>
diff --git a/Tests/Twig/Extension/Component/testBootstrapButtonGroupBasicFunction.html.txt b/Tests/Twig/Extension/Component/testBootstrapButtonGroupBasicFunction.html.txt
@@ -0,0 +1,4 @@
+<div class="btn-group" role="group">
+<button class="btn btn-default" type="button">Edit</button>
+<button class="btn btn-danger" type="button">Delete</button>
+</div>
diff --git a/Tests/Twig/Extension/Component/testBootstrapButtonGroupToolbarFunction.html.txt b/Tests/Twig/Extension/Component/testBootstrapButtonGroupToolbarFunction.html.txt
@@ -0,0 +1,4 @@
+<div class="btn-toolbar" role="toolbar">
+<button class="btn btn-default" type="button">Edit</button>
+<button class="btn btn-danger" type="button">Delete</button>
+</div>
diff --git a/Tests/Twig/Extension/Component/testBootstrapNavsJustified.html.txt b/Tests/Twig/Extension/Component/testBootstrapNavsJustified.html.txt
@@ -0,0 +1,5 @@
+<ul class="nav nav-justified">
+<li role="presentation"><a href="#">Home</a></li>
+<li role="presentation"><a href="#">Profile</a></li>
+<li role="presentation"><a href="#">Message</a></li>
+</ul>
diff --git a/Tests/Twig/Extension/Component/testBootstrapNavsPills.html.txt b/Tests/Twig/Extension/Component/testBootstrapNavsPills.html.txt
@@ -0,0 +1,5 @@
+<ul class="nav nav-pills nav-stacked">
+<li role="presentation"><a href="#">Home</a></li>
+<li role="presentation"><a href="#">Profile</a></li>
+<li role="presentation"><a href="#">Message</a></li>
+</ul>
diff --git a/Tests/Twig/Extension/Component/testBootstrapNavsPillsWithItems.html.txt b/Tests/Twig/Extension/Component/testBootstrapNavsPillsWithItems.html.txt
@@ -0,0 +1,5 @@
+<ul class="nav nav-pills">
+<li role="presentation"><a href="#">Home</a></li>
+<li role="presentation"><a href="#">Profile</a></li>
+<li role="presentation"><a href="#">Message</a></li>
+</ul>
diff --git a/Tests/Twig/Extension/Component/testBootstrapNavsTabs.html.txt b/Tests/Twig/Extension/Component/testBootstrapNavsTabs.html.txt
@@ -0,0 +1,5 @@
+<ul class="nav nav-tabs">
+<li role="presentation"><a href="#">Home</a></li>
+<li role="presentation"><a href="#">Profile</a></li>
+<li role="presentation"><a href="#">Message</a></li>
+</ul>