Fixing blank line where shebang line used to be.

webdevvie · Dec 3, 2014 · b55dceb · b55dceb
1 parent 9ed2459
commit b55dceb
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/src/lib/Herrera/Box/StubGenerator.php b/src/lib/Herrera/Box/StubGenerator.php
@@ -233,14 +233,13 @@ public function intercept($intercept)
     public function generate()
     {
         $stub = array();
+
         if ('' !== $this->shebang) {
             $stub[] = $this->shebang;
         }
 
         $stub[] = '<?php';
 
-        $stub = array($this->shebang, '<?php');
-
         if (null !== $this->banner) {
             $stub[] = $this->getBanner();
         }

diff --git a/src/tests/Herrera/Box/Tests/StubGeneratorTest.php b/src/tests/Herrera/Box/Tests/StubGeneratorTest.php
@@ -181,8 +181,6 @@ public function testGenerateExtractForced()
              ->notFound('not_found.php')
              ->rewrite('rewrite');
 
-        $phps = Phar::PHPS;
-
         $this->assertEquals(
             <<<STUB
 #!/usr/bin/env php
@@ -238,6 +236,34 @@ public function testGenerateMap()
         );
     }
 
+    /**
+     * @depends testGenerate
+     */
+    public function testGenerateNoShebang()
+    {
+        $this
+            ->generator
+            ->alias('test.phar')
+            ->shebang('');
+
+        $this->assertEquals(
+            <<<STUB
+<?php
+/**
+ * Generated by Box.
+ *
+ * @link https://github.com/herrera-io/php-box/
+ */
+if (class_exists('Phar')) {
+Phar::mapPhar('test.phar');
+}
+__HALT_COMPILER();
+STUB
+            ,
+            $this->generator->generate()
+        );
+    }
+
     public function testMimetypes()
     {
         $map = array('php' => Phar::PHPS);