Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stereo opus test to expect upmixing. #49392

Merged
merged 1 commit into from
Nov 27, 2024

Commits on Nov 27, 2024

  1. Update stereo opus test to expect upmixing.

    Update the test that sends and receives a local mono track with opus
    that on the remote side the channelCount is 2 because the opus decoder
    performs upmixing.
    
    This strange behavior is option 1) discussed in
    w3c/webrtc-pc#3010. This allows for some
    optimization and simplifications which aids in virtual audio SSRC use
    case of flip-flopping between mono and stereo signals on the wire and
    not having to re-initialize the decoder (which could cause glitches).
    
    The vibe from the November Virtual Interim
    (https://www.w3.org/2024/11/19-webrtc-minutes.html#561c) was to
    standardize what libwebrtc does when stereo is enabled, and this is
    what it does.
    
    Note: We still fail the test today though because "stereo opus" has not
    been enabled-by-default. When it is the expectation is that we pass
    both of these tests.
    
    Bug: webrtc:379996136
    Change-Id: Ibd6ee91a59d7c673bf53ad2302ba33f16b8b4ede
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6049355
    Reviewed-by: Harald Alvestrand <[email protected]>
    Commit-Queue: Henrik Boström <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#1388674}
    henbos authored and chromium-wpt-export-bot committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4b1465f View commit details
    Browse the repository at this point in the history