HTML: vertical switch #43664
Merged
HTML: vertical switch #43664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
kojiishi,
plinss,
r12a and
upsuper
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Dec 14, 2023
https://bugs.webkit.org/show_bug.cgi?id=266412 Reviewed by Aditya Keerthi. Imports web-platform-tests/wpt#43664 and changes made before. This resulted in some surrounding cleanup, presumably due to import-w3c-tests not being used last time around. * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-none-vertical-lr.optional-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-appearance-none-vertical-rl.optional-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/select-multiple-keyboard-selection.optional.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/forms/w3c-import.log: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt: Added. * LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-writing-modes/forms/checkbox-switch-input-computed-style.tentative-expected.txt: Added. Canonical link: https://commits.webkit.org/272047@main
|
I think this looks ok, if switches will be rotated like the text, which i assume is fair. An interesting aside question will be which way to rotate them (left or right). (In fact for Japanese & Chinese folks there is currently a difference in opinion about this for range controls.) cc @xfq |
|
Our plan is for the logical left to be on top when rendered vertically. |
|
Logical 'left' in LTR text. I suppose there's also the question about whether the logical movement for RTL text is reversed. See w3c/alreq#259, where i added a question about this. |
|
For RTL the switch control is reversed, at least on Apple platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For http://github.com/whatwg/html/pull/9546.