Return error for missing arguments (#946)

* Return error for missing arguments * linting * Update cmd/gitops/get/clusters/cmd.go Co-authored-by: Simon <[email protected]> * Change error message * Update error message Co-authored-by: Simon <[email protected]>
weaveworks · Oct 26, 2021 · ef7291a · ef7291a
1 parent 7af3dbf
commit ef7291a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/cmd/gitops/get/clusters/cmd.go b/cmd/gitops/get/clusters/cmd.go
@@ -1,6 +1,7 @@
 package clusters
 
 import (
+	"fmt"
 	"os"
 
 	"github.com/go-resty/resty/v2"
@@ -49,11 +50,15 @@ func getClustersCmdRunE(endpoint *string, client *resty.Client) func(*cobra.Comm
 
 		defer w.Flush()
 
-		if len(args) == 1 {
-			if clustersGetCmdFlags.Kubeconfig {
-				return clusters.GetClusterKubeconfig(args[0], r, os.Stdout)
+		if clustersGetCmdFlags.Kubeconfig {
+			if len(args) == 0 {
+				return fmt.Errorf("cluster name is required")
 			}
 
+			return clusters.GetClusterKubeconfig(args[0], r, os.Stdout)
+		}
+
+		if len(args) == 1 {
 			return clusters.GetClusterByName(args[0], r, w)
 		}
 

diff --git a/cmd/gitops/get/templates/cmd.go b/cmd/gitops/get/templates/cmd.go
@@ -65,6 +65,10 @@ func getTemplateCmdRunE(endpoint *string, client *resty.Client) func(*cobra.Comm
 		defer w.Flush()
 
 		if flags.ListTemplateParameters {
+			if len(args) == 0 {
+				return fmt.Errorf("template name is required")
+			}
+
 			return capi.GetTemplateParameters(args[0], r, w)
 		}