Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with different Spring profiles (using --spec command line argument) #803

Merged
merged 18 commits into from
Dec 4, 2024
Merged

Test with different Spring profiles (using --spec command line argument) #803

merged 18 commits into from
Dec 4, 2024

Conversation

mhdirkse
Copy link
Member

No description provided.

@mhdirkse
Copy link
Member Author

This seems to break the tests of the Test tab. An API call is expected by the beforeEach() hook but it is not seen. I do not understand why.

I understand that @MatthijsSmets is working on a progress indicator that allows for a better synchronization mechanism than waiting for API calls. I await that and then check whether this PR works.

@mhdirkse
Copy link
Member Author

Testen zijn toch nog geslaagd, maar ik ben niet tevreden. Het commando om de testen te draaien staat er nu vier keer. Daar kan ik twee keer van maken als ik een variabele invoer voor de specs.

@mhdirkse
Copy link
Member Author

Dit zou nu moeten werken, maar de Frank!Runner doet het niet meer. Hij kan de postgresql driver niet downloaden omdat de website daarvan down is.

@mhdirkse
Copy link
Member Author

Ik ga ladybug-frontend/cypress.env.json.cicd en ladybug/src/proxy.cicd.conf.json naar ladybug-frontend/.github/workflows verplaatsen als ik weer kan testen.

@mhdirkse
Copy link
Member Author

Files die ik wou verplaatsen zijn verplaatst.

@mhdirkse mhdirkse marked this pull request as ready for review November 28, 2024 12:01
MatthijsSmets
MatthijsSmets approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@MatthijsSmets MatthijsSmets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better with the matrix objects

@mhdirkse mhdirkse mentioned this pull request Dec 3, 2024
Closed
@MatthijsSmets MatthijsSmets enabled auto-merge (squash) December 3, 2024 15:10
@mhdirkse mhdirkse disabled auto-merge December 3, 2024 19:58
@mhdirkse mhdirkse enabled auto-merge (squash) December 3, 2024 20:00
@mhdirkse mhdirkse disabled auto-merge December 4, 2024 16:44
@kodiakhq kodiakhq bot merged commit 1fbfd56 into master Dec 4, 2024
3 checks passed
@kodiakhq kodiakhq bot deleted the test-with-profiles-2 branch December 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthijsSmets MatthijsSmets MatthijsSmets approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhdirkse @MatthijsSmets