Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress support "port 80" #765

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Cypress support "port 80" #765

merged 4 commits into from
Nov 1, 2024

Conversation

mhdirkse
Copy link
Member

@mhdirkse mhdirkse commented Nov 1, 2024

No description provided.

Copy link
Member

@philipsens philipsens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik zie hier geen port 80 in voor komen, alleen 8090. Klopt dat?

@mhdirkse
Copy link
Member Author

mhdirkse commented Nov 1, 2024

Ja klopt. "Poort 80" is spreekwoordelijk. Met de nieuwe input variabele krijg je de keus om de frontend te testen die in de backend zit. De default blijft dat je ladybug-frontend apart opstart, op poort 4200.

@mhdirkse
Copy link
Member Author

mhdirkse commented Nov 1, 2024

Het backend project is al aangepast. Als je de backend aanpast, dan test de ladybug-frontend test de frontend die in de backend zit.

@philipsens philipsens changed the title Cypress support "port 80" Cypress support "port 80" Nov 1, 2024
@philipsens philipsens merged commit 216cc7b into master Nov 1, 2024
2 checks passed
@philipsens philipsens deleted the cypressSupportPort80 branch November 1, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants