717 error message not shown in debug tab (#819)

* refactor: made sure errors and warnings are retrieved after setting the current view to avoid race condition * fix: wait for current view to be set so errors and warnings can be retrieved * fix: running reports cypress test to check for partial error message instead of exact value --------- Co-authored-by: mattergijz <[email protected]>
wearefrank · Dec 12, 2024 · bfcfc92 · bfcfc92
1 parent 500219d
commit bfcfc92
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/cypress/e2e/no-profile/debug/runningReports.cy.ts b/cypress/e2e/no-profile/debug/runningReports.cy.ts
@@ -59,7 +59,7 @@ describe('Test Reports in progress warning', () => {
 
   it('If threshold time has been met then show warning', () => {
     cy.get('[data-cy-debug="refresh"]').click();
-    cy.contains(`[One or more reports are in progress for more than 1 minutes]`);
+    cy.contains(`[One or more reports are in progress for more than`);
   });
 });
 
diff --git a/src/app/debug/debug.component.ts b/src/app/debug/debug.component.ts
@@ -29,7 +29,6 @@ export class DebugComponent implements OnInit {
 
   ngOnInit(): void {
     this.retrieveViews();
-    this.retrieveErrorsAndWarnings();
   }
 
   protected addReportToTree(report: Report): void {
@@ -49,7 +48,7 @@ export class DebugComponent implements OnInit {
         next: (views: View[]) => {
           this.views = views;
           if (!this.currentView) {
-            this.currentView = this.views.find((v: View) => v.defaultView)!;
+            this.onViewChange(this.views.find((v: View) => v.defaultView)!);
           }
         },
       });

diff --git a/src/app/debug/table/table.component.html b/src/app/debug/table/table.component.html
@@ -107,7 +107,7 @@
     </div>
     @if (hasTimedOut) {
       <h4 class="progress-report-timeout">[One or more reports are in progress for more
-        than {{ this.reportsInProgressThreshold ?? 1 / 1000 / 60 }} minutes]</h4>
+        than {{ (this.reportsInProgressThreshold ?? 1) / 1000 / 60 }} minutes]</h4>
     }
     <div data-cy-debug="table" class="table-responsive table-container">
       <table mat-table class="table mb-0" matSort [dataSource]="tableDataSource">