Rely on authentication token stored in cookie #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment previews on netlify for branch
|
tarrow
reviewed
May 6, 2024
| @@ -17,6 +17,10 @@ server { | |||
| root /usr/share/nginx/html; | |||
| index index.html index.html; | |||
|
|
|||
| location /api/(.*) { | |||
| proxy_pass ${API_URL}/$1; | |||
There was a problem hiding this comment.
suggestion: in a follow up PR we could add some docs to make it clear that this env var is now to be defined as the URL from the perspective of the server hosting the UI and not the client accessing it
tarrow
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://phabricator.wikimedia.org/T363100