Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whitelist.txt is superseded by allowlist.txt #111

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: whitelist.txt is superseded by allowlist.txt #111

merged 1 commit into from
Apr 17, 2024

Conversation

m90
Copy link
Contributor

@m90 m90 commented Apr 16, 2024

See: https://phabricator.wikimedia.org/T361551#9719481

This change was missed in #108 which updated to a version that does not support whitelist.txt anymore (albeit mentioned here) but instead expects allowlist.txt:

➜  queryservice git:(fr/allowlist) docker run --rm -it --entrypoint /bin/bash wikibase/wdqs:0.3.135-wmde.13                                                                                     wbaas-local
bash-4.4# cat runBlazegraph.sh | grep allowlist
ALLOWLIST=${ALLOWLIST:-"allowlist.txt"}
bash-4.4# cat runBlazegraph.sh | grep whitelist

@m90 m90 merged commit b76c9d8 into main Apr 17, 2024
3 checks passed
@m90 m90 deleted the fr/allowlist branch April 17, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants